Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artsem / Disable popovers + change color if user is barred #5191

Merged
merged 6 commits into from
Apr 28, 2022
Merged

Artsem / Disable popovers + change color if user is barred #5191

merged 6 commits into from
Apr 28, 2022

Conversation

artsemkavaleu-binary
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Apr 11, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/49NitFasE2DNJmVU5FxsNEwq5tHU
✅ Preview: https://deriv-app-git-fork-artsemkavaleu-binary-new-57034.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2022 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/5191](https://github.com/binary-com/deriv-app/pull/5191)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-artsemkavaleu-binary-new-57034.binary.sx?qa_server=frontend.binaryws.com&app_id=31580
    - **Original**: https://deriv-app-git-fork-artsemkavaleu-binary-new-57034.binary.sx
- **App ID**: `31580`

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@699dc4a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5191   +/-   ##
=========================================
  Coverage          ?   12.13%           
=========================================
  Files             ?     1247           
  Lines             ?    28380           
  Branches          ?     4835           
=========================================
  Hits              ?     3443           
  Misses            ?    24707           
  Partials          ?      230

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 699dc4a...04be8a2. Read the comment docs.

@vercel
Copy link

vercel bot commented Apr 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Apr 28, 2022 at 7:44AM (UTC)

@carolsachdeva carolsachdeva merged commit 5360d58 into binary-com:master Apr 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolsachdeva carolsachdeva carolsachdeva approved these changes

@likhith-deriv likhith-deriv likhith-deriv approved these changes

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

Assignees
No one assigned
Labels
Components P2P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artsemkavaleu-binary @codecov-commenter @carolsachdeva @likhith-deriv